Source/core/dom/Document.cpp - Issue 107513013: Remove children of title node before updating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 107513013: Remove children of title node before updating (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove children before updateTitle for less title update dispatches Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index f1ba78ad20b000246d820784d84141318c5101dc..b47b8bfda30083ddac0908176980da6c8bb8a9dc 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -1313,6 +1313,9 @@ void Document::setTitle(const String& title)

}

+ if (m_titleElement)

+ m_titleElement->removeChildren();

updateTitle(title);

if (m_titleElement && isHTMLTitleElement(m_titleElement.get()))