Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: Source/core/html/HTMLTitleElement.cpp

Issue 107513013: Remove children of title node before updating (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove children before updateTitle for less title update dispatches Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 { 85 {
86 RefPtr<Node> protectFromMutationEvents(this); 86 RefPtr<Node> protectFromMutationEvents(this);
87 87
88 int numChildren = childNodeCount(); 88 int numChildren = childNodeCount();
89 89
90 if (numChildren == 1 && firstChild()->isTextNode()) 90 if (numChildren == 1 && firstChild()->isTextNode())
91 toText(firstChild())->setData(value); 91 toText(firstChild())->setData(value);
92 else { 92 else {
93 // We make a copy here because entity of "value" argument can be Documen t::m_title, 93 // We make a copy here because entity of "value" argument can be Documen t::m_title,
94 // which goes empty during removeChildren() invocation below, 94 // which goes empty during removeChildren() invocation below,
95 // which causes HTMLTitleElement::childrenChanged(), which ends up Docum ent::setTitle(). 95 // which causes HTMLTitleElement::childrenChanged(), which ends up in Do cument::setTitleElement().
96 String valueCopy(value); 96 String valueCopy(value);
97 97
98 if (numChildren > 0) 98 if (numChildren > 0)
99 removeChildren(); 99 removeChildren();
100 100
101 appendChild(document().createTextNode(valueCopy.impl()), IGNORE_EXCEPTIO N); 101 appendChild(document().createTextNode(valueCopy.impl()), IGNORE_EXCEPTIO N);
102 } 102 }
103 } 103 }
104 104
105 } 105 }
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698