|
Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal()
Add Profile* as an argument of OpenExternal().
Disallow calling OpenExternal() from threads other than UI thread.
Changes for the implementations:
Chrome OS implementation: Use the argument Profile and stop posting tasks to UI thread.
Win implementation: Post tasks to FILE thread. (for the reason noted in external_protocol_handler.cc)
Other implementations: Just add Profile* argument and add thread check.
Changes for user code:
1. first_run_dialog.cc: Just pass Profile*.
2. browser_commands.cc: Pass Profile* acquired from Browser.
3. chrome_shell_window_delegate.cc: Pass Profile* acquired from WebContents.
4. external_protocol_handler.cc: Pass Profile* acquired with a pair of render_process_host_id and tab_contents_id.
BUG= 322682
TEST=git cl try
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240346
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+150 lines, -113 lines) |
Patch |
|
M |
chrome/browser/external_protocol/external_protocol_handler.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/external_protocol/external_protocol_handler.cc
|
View
|
|
4 chunks |
+23 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util.h
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util_android.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util_chromeos.cc
|
View
|
1
2
|
4 chunks |
+10 lines, -21 lines |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util_linux.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util_mac.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/platform_util_win.cc
|
View
|
|
2 chunks |
+36 lines, -29 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/apps/chrome_shell_window_delegate.cc
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_commands.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/external_protocol_dialog.h
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/external_protocol_dialog.mm
|
View
|
|
3 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/external_protocol_dialog_delegate.h
|
View
|
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/external_protocol_dialog_delegate.cc
|
View
|
|
2 chunks |
+9 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/first_run_dialog.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/first_run_dialog.cc
|
View
|
|
4 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/protocol_dialog_gtk.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/external_protocol_dialog.h
|
View
|
1
|
3 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/external_protocol_dialog.cc
|
View
|
1
|
4 chunks |
+13 lines, -11 lines |
0 comments
|
Download
|
Total messages: 10 (0 generated)
|