chrome/browser/ui/apps/chrome_shell_window_delegate.cc - Issue 107033003: Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_shell_window_delegate.cc

Issue 107033003: Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove is_valid check Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/apps/chrome_shell_window_delegate.cc

diff --git a/chrome/browser/ui/apps/chrome_shell_window_delegate.cc b/chrome/browser/ui/apps/chrome_shell_window_delegate.cc

index 188a66ad9d2d014ba0e5241045fa68cc2f90bc43..f30e5018313dfb62871040ab14a6d24391c3dd71 100644

--- a/chrome/browser/ui/apps/chrome_shell_window_delegate.cc

+++ b/chrome/browser/ui/apps/chrome_shell_window_delegate.cc

@@ -47,7 +47,10 @@ ShellWindowLinkDelegate::~ShellWindowLinkDelegate() {}

content::WebContents* ShellWindowLinkDelegate::OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) {

- platform_util::OpenExternal(params.url);

+ if (source) {

+ platform_util::OpenExternal(

+ Profile::FromBrowserContext(source->GetBrowserContext()), params.url);

+ }

delete source;

return NULL;

}

« no previous file with comments | « chrome/browser/platform_util_win.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »