chrome/browser/platform_util_linux.cc - Issue 107033003: Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/platform_util_linux.cc

Issue 107033003: Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove is_valid check Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/platform_util_linux.cc

diff --git a/chrome/browser/platform_util_linux.cc b/chrome/browser/platform_util_linux.cc

index 5e65bc2e1606689538a251d3bd3d042afba23e3e..002acf041d3df78d62caa6711a0cdf53a1133a11 100644

--- a/chrome/browser/platform_util_linux.cc

+++ b/chrome/browser/platform_util_linux.cc

@@ -76,7 +76,8 @@ void OpenItem(const base::FilePath& full_path) {

base::Bind(&XDGOpen, full_path.value()));

}

-void OpenExternal(const GURL& url) {

+void OpenExternal(Profile* profile, const GURL& url) {

+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (url.SchemeIs("mailto"))

XDGEmail(url.spec());

else

« no previous file with comments | « chrome/browser/platform_util_chromeos.cc ('k') | chrome/browser/platform_util_mac.mm » ('j') | no next file with comments »