Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: chrome/browser/ui/gtk/first_run_dialog.cc

Issue 107033003: Stop using GetDefaultProfile() in Chrome OS implementation of platform_util::OpenExternal() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove is_valid check Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/first_run_dialog.h ('k') | chrome/browser/ui/gtk/protocol_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/first_run_dialog.cc
diff --git a/chrome/browser/ui/gtk/first_run_dialog.cc b/chrome/browser/ui/gtk/first_run_dialog.cc
index f00212739eec8d1101c174ee83b93ba8ed79add9..3c5bde5c3d08798babd144266e2989358fdf5dac 100644
--- a/chrome/browser/ui/gtk/first_run_dialog.cc
+++ b/chrome/browser/ui/gtk/first_run_dialog.cc
@@ -37,13 +37,13 @@
namespace first_run {
bool ShowFirstRunDialog(Profile* profile) {
- return FirstRunDialog::Show();
+ return FirstRunDialog::Show(profile);
}
} // namespace first_run
// static
-bool FirstRunDialog::Show() {
+bool FirstRunDialog::Show(Profile* profile) {
bool dialog_shown = false;
#if defined(GOOGLE_CHROME_BUILD)
// If the metrics reporting is managed, we won't ask.
@@ -55,7 +55,7 @@ bool FirstRunDialog::Show() {
if (show_reporting_dialog) {
// Object deletes itself.
- new FirstRunDialog();
+ new FirstRunDialog(profile);
dialog_shown = true;
// TODO(port): it should be sufficient to just run the dialog:
@@ -69,8 +69,9 @@ bool FirstRunDialog::Show() {
return dialog_shown;
}
-FirstRunDialog::FirstRunDialog()
- : dialog_(NULL),
+FirstRunDialog::FirstRunDialog(Profile* profile)
+ : profile_(profile),
+ dialog_(NULL),
report_crashes_(NULL),
make_default_(NULL) {
ShowReportingDialog();
@@ -150,7 +151,7 @@ void FirstRunDialog::OnResponseDialog(GtkWidget* widget, int response) {
}
void FirstRunDialog::OnLearnMoreLinkClicked(GtkButton* button) {
- platform_util::OpenExternal(GURL(chrome::kLearnMoreReportingURL));
+ platform_util::OpenExternal(profile_, GURL(chrome::kLearnMoreReportingURL));
}
void FirstRunDialog::FirstRunDone() {
« no previous file with comments | « chrome/browser/ui/gtk/first_run_dialog.h ('k') | chrome/browser/ui/gtk/protocol_dialog_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698