Don't use sys.exit() in build_utils.CheckCallDie().

Don't use sys.exit() in build_utils.CheckCallDie().

Calling sys.exit() in a thread spawned by
multiprocessing.pool.ThreadPool causes an infinite hang that even SIGINT
can't fix. This is bad. Instead of calling sys.exit(), raise an
exception, crafted so that the important information (the failed
command's stdout and stderr) comes after the stacktrace and the copyable
command.

This also renames CheckCallDie() to CheckOutput() and changes it to
print stderr but not stdout by default. Suppressing stderr has hid bugs
in the past (e.g. aapt crunch failures), and hiding stdout is what we
usually want anyway.

R=cjhopman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239276

[newt (away), 2013-12-05 18:20:06]

PTAL. I think this a good solution, but it does invert the order of the
stacktrace and copyable command. The stdout and stderr of the command still
comes at the end.

[cjhopman, 2013-12-06 17:31:59]

I like this. lgtm.

https://codereview.chromium.org/106923002/diff/20001/build/android/gyp/ant.py
File build/android/gyp/ant.py (right):

https://codereview.chromium.org/106923002/diff/20001/build/android/gyp/ant.py...
build/android/gyp/ant.py:27: sys.stderr.write('Tip: run the ant command above
without the -quiet flag '
+1

[newt (away), 2013-12-06 23:26:06]

Committed patchset #2 manually as r239276 (presubmit successful).