build/android/gyp/process_resources.py - Issue 106923002: Don't use sys.exit() in build_utils.CheckCallDie().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/process_resources.py

Issue 106923002: Don't use sys.exit() in build_utils.CheckCallDie(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/process_resources.py

diff --git a/build/android/gyp/process_resources.py b/build/android/gyp/process_resources.py

index cd7fbabbfe03edc264dcd5f2e903a7c5960066bc..bf1317554e798209838650852bce3a8e90fcbea6 100755

--- a/build/android/gyp/process_resources.py

+++ b/build/android/gyp/process_resources.py

@@ -104,7 +104,7 @@ def main():

package_command.append('--non-constant-id')

if options.custom_package:

package_command += ['--custom-package', options.custom_package]

- build_utils.CheckCallDie(package_command)

+ build_utils.CheckOutput(package_command)

# Crunch image resources. This shrinks png files and is necessary for 9-patch

# images to display correctly.

@@ -113,7 +113,7 @@ def main():

'crunch',

'-S', options.crunch_input_dir,

'-C', options.crunch_output_dir]

- build_utils.CheckCallDie(aapt_cmd, suppress_output=True, fail_if_stderr=True)

+ build_utils.CheckOutput(aapt_cmd, fail_if_stderr=True)

MoveImagesToNonMdpiFolders(options.crunch_output_dir)