Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/gyp/javac.py

Issue 106923002: Don't use sys.exit() in build_utils.CheckCallDie(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/gyp/ant.py ('K') | « build/android/gyp/jar_toc.py ('k') | build/android/gyp/process_resources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index c1170048b523b433ae10c3c346581080c4931228..22a4f97d8743f8595fe14d5512eba71cfb566447 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -59,8 +59,7 @@ def DoJavac(options):
# not contain the corresponding old .class file after running this action.
build_utils.DeleteDirectory(output_dir)
build_utils.MakeDirectory(output_dir)
- suppress_output = not options.chromium_code
- build_utils.CheckCallDie(javac_cmd, suppress_output=suppress_output)
+ build_utils.CheckOutput(javac_cmd, print_stdout=options.chromium_code)
record_path = '%s/javac.md5.stamp' % options.output_dir
md5_check.CallAndRecordIfStale(
« build/android/gyp/ant.py ('K') | « build/android/gyp/jar_toc.py ('k') | build/android/gyp/process_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698