Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: build/android/gyp/finalize_apk.py

Issue 106923002: Don't use sys.exit() in build_utils.CheckCallDie(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/finalize_apk.py
diff --git a/build/android/gyp/finalize_apk.py b/build/android/gyp/finalize_apk.py
index 0b1d2c258af670104a2b6da848b146e605435467..6e4685ce6d1f610c5a4a6fbb3cee386eb1782b41 100755
--- a/build/android/gyp/finalize_apk.py
+++ b/build/android/gyp/finalize_apk.py
@@ -26,7 +26,7 @@ def SignApk(keystore_path, unsigned_path, signed_path):
signed_path,
'chromiumdebugkey',
]
- build_utils.CheckCallDie(sign_cmd)
+ build_utils.CheckOutput(sign_cmd)
def AlignApk(android_sdk_root, unaligned_path, final_path):
@@ -36,7 +36,7 @@ def AlignApk(android_sdk_root, unaligned_path, final_path):
unaligned_path,
final_path,
]
- build_utils.CheckCallDie(align_cmd)
+ build_utils.CheckOutput(align_cmd)
def main(argv):

Powered by Google App Engine
This is Rietveld 408576698