Issue 1068823004: Fixes bug in LoadIndexedInstr on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1068823004: Fixes bug in LoadIndexedInstr on ARM. (Closed)

Created:
5 years, 8 months ago by zra

Modified:
5 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes bug in LoadIndexedInstr on ARM. Assembler::ElementAddressForRegIndex already untags the index. On MIPS, the removed instruction had no effect. BUG=https://code.google.com/p/dart/issues/detail?id=22384 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44955

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -6 lines)			Patch
M	runtime/vm/dart_api_impl_test.cc	View	1	2 chunks	+69 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

5 years, 8 months ago (2015-04-07 23:48:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44955 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages