Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 1068823004: Fixes bug in LoadIndexedInstr on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1293 case kTypedDataFloat32x4ArrayCid: 1293 case kTypedDataFloat32x4ArrayCid:
1294 UNIMPLEMENTED(); 1294 UNIMPLEMENTED();
1295 break; 1295 break;
1296 } 1296 }
1297 return; 1297 return;
1298 } 1298 }
1299 1299
1300 if ((representation() == kUnboxedUint32) || 1300 if ((representation() == kUnboxedUint32) ||
1301 (representation() == kUnboxedInt32)) { 1301 (representation() == kUnboxedInt32)) {
1302 const Register result = locs()->out(0).reg(); 1302 const Register result = locs()->out(0).reg();
1303 if ((index_scale() == 1) && index.IsRegister()) {
1304 __ SmiUntag(index.reg());
1305 }
1306 switch (class_id()) { 1303 switch (class_id()) {
1307 case kTypedDataInt32ArrayCid: 1304 case kTypedDataInt32ArrayCid:
1308 ASSERT(representation() == kUnboxedInt32); 1305 ASSERT(representation() == kUnboxedInt32);
1309 __ lw(result, element_address); 1306 __ lw(result, element_address);
1310 break; 1307 break;
1311 case kTypedDataUint32ArrayCid: 1308 case kTypedDataUint32ArrayCid:
1312 ASSERT(representation() == kUnboxedUint32); 1309 ASSERT(representation() == kUnboxedUint32);
1313 __ lw(result, element_address); 1310 __ lw(result, element_address);
1314 break; 1311 break;
1315 default: 1312 default:
(...skipping 4304 matching lines...) Expand 10 before | Expand all | Expand 10 after
5620 1, 5617 1,
5621 locs()); 5618 locs());
5622 __ lw(result, Address(SP, 1 * kWordSize)); 5619 __ lw(result, Address(SP, 1 * kWordSize));
5623 __ addiu(SP, SP, Immediate(2 * kWordSize)); 5620 __ addiu(SP, SP, Immediate(2 * kWordSize));
5624 } 5621 }
5625 5622
5626 5623
5627 } // namespace dart 5624 } // namespace dart
5628 5625
5629 #endif // defined TARGET_ARCH_MIPS 5626 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698