chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 1064823002: Componentize FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index ee646d4323a383958528077a023513023b5630fc..23a17e93db93786de82decba142bcd74c2667126 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -509,7 +509,8 @@ void BrowserTabStripController::SetTabRendererDataFromModel(

data->crashed_status = contents->GetCrashedStatus();

data->incognito = contents->GetBrowserContext()->IsOffTheRecord();

data->mini = model_->IsMiniTab(model_index);

- data->show_icon = data->mini || favicon_tab_helper->ShouldDisplayFavicon();

+ data->show_icon =

+ data->mini || FaviconTabHelper::ShouldDisplayFavicon(contents);

data->blocked = model_->IsTabBlocked(model_index);

data->app = extensions::TabHelper::FromWebContents(contents)->is_app();

data->media_state = chrome::GetTabMediaStateForContents(contents);