chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 1064823002: Componentize FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index c13b36210e8ed17c2b9ef63db72db3d847a129dc..8dde6a25c0e810e8642963257cacec6c36ee1050 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -1554,10 +1554,8 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {

NSInteger index = [self indexFromModelIndex:modelIndex];

TabController* tabController = [tabArray_ objectAtIndex:index];

- FaviconTabHelper* favicon_tab_helper =

- FaviconTabHelper::FromWebContents(contents);

bool oldHasIcon = [tabController iconView] != nil;

- bool newHasIcon = favicon_tab_helper->ShouldDisplayFavicon() ||

+ bool newHasIcon = FaviconTabHelper::ShouldDisplayFavicon(contents) ||

tabStripModel_->IsMiniTab(modelIndex); // Always show icon if mini.

TabLoadingState oldState = [tabController loadingState];