components/favicon.gypi - Issue 1064823002: Componentize FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon.gypi

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/favicon/favicon_tab_helper_browsertest.cc ('K') | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | components/favicon/DEPS » ('j') | components/favicon/content/content_favicon_driver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon.gypi

diff --git a/components/favicon.gypi b/components/favicon.gypi

index f2c9cf54b7459b8b634d8f0349a052b64698f796..c4e71026fce234c97b4bbca2cf5d7f1c2de4f5a9 100644

--- a/components/favicon.gypi

+++ b/components/favicon.gypi

@@ -10,6 +10,7 @@

'type': 'static_library',

'dependencies': [

'../skia/skia.gyp:skia',

+ '../ui/base/ui_base.gyp:ui_base',

'../ui/gfx/gfx.gyp:gfx',

'../url/url.gyp:url_lib',

'bookmarks_browser',

@@ -23,7 +24,10 @@

'favicon/core/fallback_icon_service.cc',

'favicon/core/fallback_icon_service.h',

'favicon/core/favicon_client.h',

+ 'favicon/core/favicon_driver.cc',

'favicon/core/favicon_driver.h',

+ 'favicon/core/favicon_driver_impl.cc',

+ 'favicon/core/favicon_driver_impl.h',

'favicon/core/favicon_driver_observer.h',

'favicon/core/favicon_handler.cc',

'favicon/core/favicon_handler.h',

@@ -52,6 +56,8 @@

'sources': [

# Note: sources list duplicated in GN build.

+ 'favicon/content/content_favicon_driver.cc',

+ 'favicon/content/content_favicon_driver.h',

'favicon/content/favicon_url_util.cc',

'favicon/content/favicon_url_util.h',

@@ -72,8 +78,10 @@

'favicon_core',

'sources': [

- 'favicon/ios/favicon_url_util.h',

'favicon/ios/favicon_url_util.cc',

+ 'favicon/ios/favicon_url_util.h',

+ 'favicon/ios/web_favicon_driver.cc',

+ 'favicon/ios/web_favicon_driver.h',

'include_dirs': [

'..',