Componentize FaviconTabHelper

chrome/browser/favicon/favicon_tab_helper_browsertest.cc

Index: chrome/browser/favicon/favicon_tab_helper_browsertest.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper_browsertest.cc b/chrome/browser/favicon/favicon_tab_helper_browsertest.cc
index 8722b5b027f177ba9d49005dc7ff52ac12e39986..567d825f76ae1dab6735131a26b8592de1a2ccb7 100644
--- a/chrome/browser/favicon/favicon_tab_helper_browsertest.cc
+++ b/chrome/browser/favicon/favicon_tab_helper_browsertest.cc
@@ -187,11 +187,8 @@ class FaviconTabHelperTest : public InProcessBrowserTest,
 
   // FaviconTabHelperPendingTaskChecker:
   bool HasPendingTasks() override {
-    favicon::FaviconHandler* favicon_handler =
-        FaviconTabHelper::FromWebContents(web_contents())
-            ->favicon_handler_.get();
-    return !favicon_handler->download_requests_.empty() ||
-        favicon_handler->cancelable_task_tracker_.HasTrackedTasks();
+    return FaviconTabHelper::FromWebContents(web_contents())
+        ->HasPendingTasksForTest();

[droger, 2015/04/07 15:33:24]

Why do we need the method on FaviconTabHelper? The existing code is using only
FaviconHandler, could the method be on FaviconHandler only?

[sdefresne, 2015/04/07 16:50:06]

There is no public method to get the FaviconHandler owned by the
FaviconDriverImpl. Exposing the method on FaviconDriverImpl appeared to be the
cleanest way to fix this test.

   }
 
  private: