Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1064813003: ARM64: Support sign extend for add and subtract (Closed)

Created:
5 years, 8 months ago by martyn.capewell
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: Support sign extend for add and subtract Support sxtb and sxth extend operators on add and subtract, as we've done for ubtx/h. This is similar to ARM support for sxtab/h. BUG= Committed: https://crrev.com/8e846a61660ae849a0e6cc8a43376a97f412927b Cr-Commit-Position: refs/heads/master@{#27624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -46 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +11 lines, -9 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +49 lines, -33 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 6 chunks +98 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
5 years, 8 months ago (2015-04-07 09:34:08 UTC) #2
Benedikt Meurer
Nice. LGTM
5 years, 8 months ago (2015-04-07 10:20:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064813003/1
5 years, 8 months ago (2015-04-07 11:07:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 11:34:37 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 11:34:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e846a61660ae849a0e6cc8a43376a97f412927b
Cr-Commit-Position: refs/heads/master@{#27624}

Powered by Google App Engine
This is Rietveld 408576698