Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1064523002: [sql] Clients should use sql::Connection::Delete(). (Closed)

Created:
5 years, 8 months ago by Scott Hess - ex-Googler
Modified:
5 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, felt, grt+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Clients should use sql::Connection::Delete(). sql::Connection::Delete() covers associated journal files. BUG=none Committed: https://crrev.com/6937777844c96c071745be6f46ad6e6ce3d6c9f1 Cr-Commit-Position: refs/heads/master@{#324365}

Patch Set 1 #

Patch Set 2 : Drop unnecessary change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Scott Hess - ex-Googler
Minor cleanup I found in my repo. erikwright for content/browser/net/sqlite_persistent_cookie_store.cc gcasto for components/password_manager/core/browser/login_database_unittest.cc felt for ...
5 years, 8 months ago (2015-04-06 20:24:57 UTC) #2
felt
chrome/browser/extensions/activity_log/activity_database_unittest.cc lgtm
5 years, 8 months ago (2015-04-06 20:26:05 UTC) #3
Garrett Casto
passwords LGTM
5 years, 8 months ago (2015-04-06 20:28:15 UTC) #4
erikwright (departed)
LGTM
5 years, 8 months ago (2015-04-07 22:41:03 UTC) #5
Scott Hess - ex-Googler
On 2015/04/06 20:24:57, Scott Hess wrote: > cpu for chrome/browser/diagnostics/sqlite_diagnostics.cc Ping for Carlos.
5 years, 8 months ago (2015-04-08 17:09:46 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm sorry for the delay.
5 years, 8 months ago (2015-04-09 00:03:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064523002/20001
5 years, 8 months ago (2015-04-09 01:22:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 04:14:40 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 04:15:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6937777844c96c071745be6f46ad6e6ce3d6c9f1
Cr-Commit-Position: refs/heads/master@{#324365}

Powered by Google App Engine
This is Rietveld 408576698