chrome/browser/diagnostics/sqlite_diagnostics.cc - Issue 1064523002: [sql] Clients should use sql::Connection::Delete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/sqlite_diagnostics.cc

Issue 1064523002: [sql] Clients should use sql::Connection::Delete(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop unnecessary change. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/diagnostics/sqlite_diagnostics.cc

diff --git a/chrome/browser/diagnostics/sqlite_diagnostics.cc b/chrome/browser/diagnostics/sqlite_diagnostics.cc

index b2746227abc9a999897c28ac05fa3cc6fc17b4e5..b342bba12048aec87fe71812cfabf4b9a01960a6 100644

--- a/chrome/browser/diagnostics/sqlite_diagnostics.cc

+++ b/chrome/browser/diagnostics/sqlite_diagnostics.cc

@@ -56,7 +56,7 @@ class SqliteIntegrityTest : public DiagnosticsTest {

case DIAG_SQLITE_DB_CORRUPTED:

LOG(WARNING) << "Removing broken SQLite database: "

<< db_path_.value();

- base::DeleteFile(db_path_, false);

+ sql::Connection::Delete(db_path_);

break;

case DIAG_SQLITE_SUCCESS:

case DIAG_SQLITE_FILE_NOT_FOUND_OK:

« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_database_unittest.cc » ('j') | no next file with comments »