components/password_manager/core/browser/login_database_unittest.cc - Issue 1064523002: [sql] Clients should use sql::Connection::Delete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 1064523002: [sql] Clients should use sql::Connection::Delete(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop unnecessary change. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_database_unittest.cc ('k') | content/browser/net/sqlite_persistent_cookie_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc

index e9b8732966e8613a6cd2f7b3b4e2e4cc6583d3b8..c45cc5f40aed23079159ebddbf9f3d7ec990ad61 100644

--- a/components/password_manager/core/browser/login_database_unittest.cc

+++ b/components/password_manager/core/browser/login_database_unittest.cc

@@ -1141,7 +1141,7 @@ class LoginDatabaseMigrationTest : public testing::TestWithParam<int> {

void DestroyDatabase() {

if (!database_path_.empty())

- base::DeleteFile(database_path_, false);

+ sql::Connection::Delete(database_path_);

}

// Returns an empty vector on failure. Otherwise returns the values of the