chrome/browser/extensions/activity_log/activity_database_unittest.cc - Issue 1064523002: [sql] Clients should use sql::Connection::Delete().

Unified Diff: chrome/browser/extensions/activity_log/activity_database_unittest.cc

Issue 1064523002: [sql] Clients should use sql::Connection::Delete(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop unnecessary change. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/diagnostics/sqlite_diagnostics.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_database_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_database_unittest.cc b/chrome/browser/extensions/activity_log/activity_database_unittest.cc

index 39443841596dacdbd9f89650191be9cc56e5efca..7d498980b6ee64c78386ceb46049670fb78028b5 100644

--- a/chrome/browser/extensions/activity_log/activity_database_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_database_unittest.cc

@@ -174,7 +174,7 @@ TEST_F(ActivityDatabaseTest, Init) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityInit.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

ActivityDatabase* activity_db = OpenDatabase(db_file);

activity_db->Close();

@@ -191,7 +191,7 @@ TEST_F(ActivityDatabaseTest, RecordAction) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityRecord.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

ActivityDatabase* activity_db = OpenDatabase(db_file);

activity_db->SetBatchModeForTesting(false);

@@ -210,7 +210,7 @@ TEST_F(ActivityDatabaseTest, BatchModeOff) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityRecord.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

// Record some actions

ActivityDatabase* activity_db = OpenDatabase(db_file);

@@ -228,7 +228,7 @@ TEST_F(ActivityDatabaseTest, BatchModeOn) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityRecord.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

// Record some actions

ActivityDatabase* activity_db = OpenDatabase(db_file);

@@ -250,7 +250,7 @@ TEST_F(ActivityDatabaseTest, BatchModeFlush) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityFlush.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

// Record some actions

ActivityDatabase* activity_db = OpenDatabase(db_file);

@@ -272,7 +272,7 @@ TEST_F(ActivityDatabaseTest, InitFailure) {

base::FilePath db_file;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

db_file = temp_dir.path().AppendASCII("ActivityRecord.db");

- base::DeleteFile(db_file, false);

+ sql::Connection::Delete(db_file);

ActivityDatabaseTestPolicy* delegate = new ActivityDatabaseTestPolicy();

ActivityDatabase* activity_db = new ActivityDatabase(delegate);