Add a "Max. MSAA samples" entry to chrome://gpu.

Add a "Max. MSAA samples" entry to chrome://gpu.

BUG=474727
Committed: https://crrev.com/b7a64d5752ffb18bd7916eda0977222a8085bace
Cr-Commit-Position: refs/heads/master@{#324236}

[Stephen White, 2015-04-07 20:43:11]

senorblanco@chromium.org changed reviewers:
+ inferno@chromium.org, kbr@chromium.org

[Stephen White, 2015-04-07 20:45:12]

inferno@: for content/common/gpu/gpu_messages.h
kbr@: for everything else

Also, let me know if UI people need to know about changes to chrome://gpu.

[inferno, 2015-04-07 20:50:24]

inferno@chromium.org changed reviewers:
+ tsepez@chromium.org
- inferno@chromium.org

[Ken Russell (switch to Gerrit), 2015-04-07 22:13:27]

lgtm with one comment.

I don't think changes to about:gpu's content need to be approved by the UX team.

https://codereview.chromium.org/1063233002/diff/1/gpu/config/gpu_info.cc
File gpu/config/gpu_info.cc (right):

https://codereview.chromium.org/1063233002/diff/1/gpu/config/gpu_info.cc#newc...
gpu/config/gpu_info.cc:82: std::string max_msaa_samples;
Please enumerate this new field further down in GPUInfo::EnumerateFields -- this
will expose it to Telemetry and the GPU tests in case that's useful later -- and
update gpu_info_unittest too. Search for gl_ws_vendor as an example of another
similarly handled field.

[Tom Sepez, 2015-04-07 22:16:45]

Messages LGTM.

[Stephen White, 2015-04-08 12:19:35]

https://codereview.chromium.org/1063233002/diff/1/gpu/config/gpu_info.cc
File gpu/config/gpu_info.cc (right):

https://codereview.chromium.org/1063233002/diff/1/gpu/config/gpu_info.cc#newc...
gpu/config/gpu_info.cc:82: std::string max_msaa_samples;
On 2015/04/07 22:13:27, Ken Russell wrote:
> Please enumerate this new field further down in GPUInfo::EnumerateFields --
this
> will expose it to Telemetry and the GPU tests in case that's useful later --
and
> update gpu_info_unittest too. Search for gl_ws_vendor as an example of another
> similarly handled field.

Done.

[Stephen White, 2015-04-08 12:24:19]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-04-08 12:24:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1063233002/#ps20001
(title: "Changes per kbr's comments")

[commit-bot: I haz the power, 2015-04-08 12:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063233002/20001

[commit-bot: I haz the power, 2015-04-08 16:59:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-08 17:00:11]

Patchset 2 (id:??) landed as
https://crrev.com/b7a64d5752ffb18bd7916eda0977222a8085bace
Cr-Commit-Position: refs/heads/master@{#324236}