Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1057873004: Pass a ui::PaintContext from ui::Layer to layer delegates. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, sievers+watch_chromium.org, alicet1, stevenjb+watch_chromium.org, tdanderson+views_chromium.org, msw+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, penghuang+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, shuchen+watch_chromium.org, danakj+watch_chromium.org, James Su, davemoore+watch_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass a ui::PaintContext from ui::Layer to layer delegates. This is a plumbing CL to create a ui::PaintContext that wraps a gfx::Canvas up in ui::Layer. This is passed to every LayerDelegate, and also through to aura::WindowDelegates and views::NativeWidgetDelegates to eventually reach views::View as well. This way ui::PaintContext is created in one place (for compositor paints, there are other places painting to bitmaps we'll address later). And in the future the ui::PaintContext can be backed by a display list instead of a canvas. R=sky BUG=466426 Committed: https://crrev.com/85d970e4cc6d5f71c30a94cd31d6f0fa07b38890 Cr-Commit-Position: refs/heads/master@{#323855}

Patch Set 1 #

Patch Set 2 : layer-paintcontext: . #

Patch Set 3 : layer-paintcontext: rebase #

Patch Set 4 : layer-paintcontext: . #

Patch Set 5 : layer-paintcontext: . #

Patch Set 6 : layer-paintcontext: . #

Patch Set 7 : layer-paintcontext: mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -111 lines) Patch
M ash/display/cursor_window_controller.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/partial_screenshot_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/aura/window.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/window.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ui/aura/window_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura_extra/image_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_extra/image_window_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/compositor/layer.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/compositor/layer.cc View 5 chunks +5 lines, -14 lines 0 comments Download
M ui/compositor/layer_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/image_grid.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/image_grid.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
danakj
Sorry for yet another plumbing CL. This should get us through all of that mess, ...
5 years, 8 months ago (2015-04-02 20:59:34 UTC) #2
piman
LGTM for content/ and ui/compositor
5 years, 8 months ago (2015-04-02 21:16:50 UTC) #3
sky
LGTM
5 years, 8 months ago (2015-04-02 23:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/20001
5 years, 8 months ago (2015-04-03 19:54:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/11845) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 20:00:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/40001
5 years, 8 months ago (2015-04-03 20:08:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/75621)
5 years, 8 months ago (2015-04-03 20:25:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/60001
5 years, 8 months ago (2015-04-03 20:31:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/75636)
5 years, 8 months ago (2015-04-03 20:48:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/80001
5 years, 8 months ago (2015-04-03 20:51:30 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/24451) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 21:09:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/100001
5 years, 8 months ago (2015-04-03 22:03:26 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/40251)
5 years, 8 months ago (2015-04-03 22:36:38 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057873004/120001
5 years, 8 months ago (2015-04-03 22:39:26 UTC) #32
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 8 months ago (2015-04-04 00:15:39 UTC) #33
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:16:22 UTC) #34
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/85d970e4cc6d5f71c30a94cd31d6f0fa07b38890
Cr-Commit-Position: refs/heads/master@{#323855}

Powered by Google App Engine
This is Rietveld 408576698