Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll()

Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll() (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto

Modified:
5 years, 8 months ago

Reviewers:
kinuko, Justin Novosad

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Revert of ServiceWorker: Remove Clients.getAll() (patchset #1 id:1 of https://codereview.chromium.org/1057893002/) Reason for revert: The chromium test has been fixed in https://codereview.chromium.org/1051253003/. Original issue's description: > Revert of ServiceWorker: Remove Clients.getAll() (patchset #1 id:20001 of https://codereview.chromium.org/1052523005/) > > Reason for revert: > This is causing browser test failures: > http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/9247/steps/browser_tests/logs/stdio > > getAll() is still used in tests that live in the chromium repository. Right here: src/chrome/test/data/push_messaging/service_worker.js > > Original issue's description: > > ServiceWorker: Remove Clients.getAll() > > > > Intent to rename thread: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h8hBAkca8NE > > > > BUG=451334 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193000 > > TBR=kinuko@chromium.org,ksakamoto@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=451334 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193036 TBR=kinuko@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193058

Patch Set 1 #

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/modules/serviceworkers/Clients.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

Created Revert of Revert of ServiceWorker: Remove Clients.getAll()

5 years, 8 months ago (2015-04-03 00:44:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056973003/1

5 years, 8 months ago (2015-04-03 00:46:59 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 00:48:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193058

Expand Messages | Collapse Messages