Issue 1057893002: Revert of ServiceWorker: Remove Clients.getAll()

Issue 1057893002: Revert of ServiceWorker: Remove Clients.getAll() (Closed)

Created:
5 years, 8 months ago by Justin Novosad

Modified:
5 years, 8 months ago

Reviewers:
kinuko, Kunihiko Sakamoto

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of ServiceWorker: Remove Clients.getAll() (patchset #1 id:20001 of https://codereview.chromium.org/1052523005/) Reason for revert: This is causing browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/9247/steps/browser_tests/logs/stdio getAll() is still used in tests that live in the chromium repository. Right here: src/chrome/test/data/push_messaging/service_worker.js Original issue's description: > ServiceWorker: Remove Clients.getAll() > > Intent to rename thread: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h8hBAkca8NE > > BUG=451334 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193000 TBR=kinuko@chromium.org,ksakamoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193036

Patch Set 1 #

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -12 lines)			Patch
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/postmessage-to-client-worker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/serviceworkers/Clients.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

Created Revert of ServiceWorker: Remove Clients.getAll()

5 years, 8 months ago (2015-04-02 13:59:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057893002/1

5 years, 8 months ago (2015-04-02 13:59:23 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=193036

5 years, 8 months ago (2015-04-02 14:00:01 UTC) #3

Kunihiko Sakamoto

5 years, 8 months ago (2015-04-03 00:44:44 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1056973003/ by ksakamoto@chromium.org.

The reason for reverting is: The chromium test has been fixed in
https://codereview.chromium.org/1051253003/..

Expand Messages | Collapse Messages