LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js - Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

diff --git a/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js b/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

index b86a4e59e43a88f62f063889d1b0f8aec531ecc2..caf3d8a6ad61d84300160b7801a7e8f07e9f99ae 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

@@ -21,7 +21,7 @@

function testOutOfStackOutOfWaitUntil() {

synthesizeNotificationClick().then(function() {

- self.clients.getAll().then(function() {

+ self.clients.matchAll().then(function() {

clients.openWindow('/foo.html').catch(function() {

self.postMessage('openWindow() in notificationclick outside of waitUntil not in stack failed');

}).then(runNextTestOrQuit);

@@ -31,7 +31,7 @@

function testInWaitUntilAsyncAndDoubleCall() {

synthesizeNotificationClick().then(function(e) {

- e.waitUntil(self.clients.getAll().then(function() {

+ e.waitUntil(self.clients.matchAll().then(function() {

return clients.openWindow('/foo.html').then(function() {

self.postMessage('openWindow() in notificationclick\'s waitUntil suceeded');

}).then(runNextTestOrQuit);

@@ -41,7 +41,7 @@

function testDoubleCallInWaitUntilAsync() {

synthesizeNotificationClick().then(function(e) {

- e.waitUntil(self.clients.getAll().then(function() {

+ e.waitUntil(self.clients.matchAll().then(function() {

return clients.openWindow('/foo.html').then(function() {

return clients.openWindow('/foo.html');

}).catch(function() {