LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js - Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js

Issue 1056973003: Revert of Revert of ServiceWorker: Remove Clients.getAll() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js ('k') | LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js

diff --git a/LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js b/LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js

index 6211c156b1b273ca47fe9e9f6221f2aeb22180ee..7b97ace2352a02a66b1b22ed5d82abc2249ad4a7 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js

@@ -9,7 +9,7 @@

// Override self.initialize() from sw-test-helpers.js

self.initialize = function() {

- return self.clients.getAll().then(function(clients) {

+ return self.clients.matchAll().then(function(clients) {

clients.forEach(function(c) {

// All clients are iframes but one of them embeds the other ones. We

// want to use that one as the main |client|.

@@ -23,7 +23,7 @@

};

function getNumberOfFocusedClients() {

- return self.clients.getAll().then(function(clients) {

+ return self.clients.matchAll().then(function(clients) {

var focusedClients = 0;

clients.forEach(function(c) {

if (c.focused)