Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1056633004: Update {virtual,override} to follow C++11 style in components. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 7 months ago
Reviewers:
Nico, Cait (Slow)
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, jam, plaree+watch_chromium.org, noyau+watch_chromium.org, darin-cc_chromium.org, tfarina, estade+watch_chromium.org, gcasto+watchlist_chromium.org, maniscalco+watch_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in components. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de Cr-Commit-Position: refs/heads/master@{#327312}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : fix logo tracker unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -255 lines) Patch
M components/autofill/content/browser/wallet/mock_wallet_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/exit_funnel_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_test_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/dom_distiller/core/fake_distiller.h View 2 chunks +6 lines, -8 lines 0 comments Download
M components/dom_distiller/core/fake_distiller_page.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/viewer_unittest.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M components/enhanced_bookmarks/image_store_ios_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/image_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/invalidation/unacked_invalidation_set_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/leveldb_proto/proto_database_impl.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/leveldb_proto/testing/fake_db.h View 1 chunk +5 lines, -7 lines 0 comments Download
M components/nacl/broker/nacl_broker_listener.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/nacl/browser/nacl_broker_host_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/native_viewport/platform_viewport_android.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/async_policy_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/policy_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/policy_loader_win.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 4 chunks +48 lines, -52 lines 0 comments Download
M components/policy/core/common/policy_service_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/client_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/proximity_auth/connection_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/renderer_context_menu/render_view_context_menu_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_win.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/storage_monitor/storage_monitor_win_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/storage_monitor/test_portable_device_watcher_win.h View 2 chunks +4 lines, -5 lines 0 comments Download
M components/storage_monitor/test_storage_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/test_storage_monitor_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.h View 2 chunks +4 lines, -6 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/test/run_all_unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/update_client/background_downloader_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/common/web_data_results.h View 2 chunks +3 lines, -4 lines 0 comments Download
M components/wifi/wifi_service_win.cc View 1 chunk +33 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-22 21:11:57 UTC) #2
ncarter (slow)
On 2015/04/22 21:11:57, ncarter wrote: Whoops -- please do not review. This patch has compile ...
5 years, 8 months ago (2015-04-22 21:12:59 UTC) #3
tfarina
Could you include the regex in the cl description? It is useful for others.
5 years, 8 months ago (2015-04-22 21:20:08 UTC) #5
ncarter (slow)
On 2015/04/22 21:20:08, tfarina wrote: > Could you include the regex in the cl description? ...
5 years, 8 months ago (2015-04-22 21:27:18 UTC) #6
ncarter (slow)
caitkp: Please review! Thanks.
5 years, 8 months ago (2015-04-24 20:24:34 UTC) #8
ncarter (slow)
On 2015/04/24 20:24:34, ncarter wrote: > caitkp: Please review! Thanks. caitkp: friendly ping on this ...
5 years, 8 months ago (2015-04-27 22:05:40 UTC) #9
Cait (Slow)
LGTM -- thanks for the clean-up!
5 years, 7 months ago (2015-04-28 13:59:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056633004/40001
5 years, 7 months ago (2015-04-28 16:19:51 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 17:22:27 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 17:23:22 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de
Cr-Commit-Position: refs/heads/master@{#327312}

Powered by Google App Engine
This is Rietveld 408576698