components/policy/core/common/cloud/policy_builder.h - Issue 1056633004: Update {virtual,override} to follow C++11 style in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_builder.h

Issue 1056633004: Update {virtual,override} to follow C++11 style in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix logo tracker unittest. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/async_policy_provider_unittest.cc ('k') | components/policy/core/common/policy_loader_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/policy_builder.h

diff --git a/components/policy/core/common/cloud/policy_builder.h b/components/policy/core/common/cloud/policy_builder.h

index c0dd09962c24d86e4abaac73b47a074ea044b40b..cfc1076ae240d81c518357e7174ae626c926a4e0 100644

--- a/components/policy/core/common/cloud/policy_builder.h

+++ b/components/policy/core/common/cloud/policy_builder.h

@@ -121,7 +121,7 @@ template<typename PayloadProto>

class TypedPolicyBuilder : public PolicyBuilder {

public:

TypedPolicyBuilder();

- virtual ~TypedPolicyBuilder() {}

+ ~TypedPolicyBuilder() override {}

// Returns a reference to the payload protobuf being built.

PayloadProto& payload() {

@@ -134,7 +134,7 @@ class TypedPolicyBuilder : public PolicyBuilder {

}

// PolicyBuilder:

- virtual void Build() override {

+ void Build() override {

if (payload_.get())

CHECK(payload_->SerializeToString(policy_data().mutable_policy_value()));