Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed. (Closed)

Created:
5 years, 8 months ago by ramant (doing other things)
Modified:
5 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Crash when there is a bad packet loss and the session is closed. Fix is to notify the factory about session being closed. BUG=473884 R=rch@chromium.org Committed: https://crrev.com/41633b1fd365d7e091722e25df6431d8abca658e Cr-Commit-Position: refs/heads/master@{#323887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M net/quic/quic_client_session.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +13 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 8 months ago (2015-04-04 01:07:34 UTC) #1
Ryan Hamilton
lgtm
5 years, 8 months ago (2015-04-04 03:08:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056263002/1
5 years, 8 months ago (2015-04-05 16:23:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-05 18:20:06 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-05 18:20:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41633b1fd365d7e091722e25df6431d8abca658e
Cr-Commit-Position: refs/heads/master@{#323887}

Powered by Google App Engine
This is Rietveld 408576698