net/quic/quic_stream_factory.cc - Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.cc

Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_factory.cc

diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc

index 9bebb57fa54cf3c902ffdd463e57c6325b7d2290..9776448cc5f0aa3948d3998b395675b637c8b55e 100644

--- a/net/quic/quic_stream_factory.cc

+++ b/net/quic/quic_stream_factory.cc

@@ -790,7 +790,8 @@ bool QuicStreamFactory::OnHandshakeConfirmed(QuicClientSession* session,

}

// We abandon the connection if packet loss rate is too bad.

- session->CloseSessionOnError(ERR_ABORTED, QUIC_BAD_PACKET_LOSS_RATE);

+ session->CloseSessionOnErrorAndNotifyFactoryLater(ERR_ABORTED,

+ QUIC_BAD_PACKET_LOSS_RATE);

if (IsQuicDisabled(port))

return true; // Exit if Quic is already disabled for this port.

« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »