Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 39618db9118845c16f32f970111e1baaca994f36..dd7865bd5138b34a1969b966186b5c98da47f912 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -1746,6 +1746,7 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
// Set packet_loss_rate to a lower value than packet_loss_threshold.
EXPECT_FALSE(
factory_.OnHandshakeConfirmed(session, /*packet_loss_rate=*/0.9f));
+ EXPECT_TRUE(session->connection()->connected());
EXPECT_TRUE(QuicStreamFactoryPeer::HasActiveSession(
&factory_, host_port_pair_, is_https_));
EXPECT_FALSE(
@@ -1793,6 +1794,7 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
factory_.OnHandshakeConfirmed(session2, /*packet_loss_rate=*/1.0f));
EXPECT_EQ(1, QuicStreamFactoryPeer::GetNumberOfLossyConnections(
&factory_, server2.port()));
+ EXPECT_FALSE(session2->connection()->connected());
EXPECT_FALSE(
QuicStreamFactoryPeer::IsQuicDisabled(&factory_, server2.port()));
EXPECT_FALSE(
@@ -1814,6 +1816,7 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
factory_.OnHandshakeConfirmed(session3, /*packet_loss_rate=*/1.0f));
EXPECT_EQ(2, QuicStreamFactoryPeer::GetNumberOfLossyConnections(
&factory_, server3.port()));
+ EXPECT_FALSE(session2->connection()->connected());
EXPECT_TRUE(QuicStreamFactoryPeer::IsQuicDisabled(&factory_, server3.port()));
EXPECT_FALSE(
QuicStreamFactoryPeer::HasActiveSession(&factory_, server3, is_https_));
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698