QUIC - Crash when there is a bad packet loss and the session is closed.

net/quic/quic_client_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A client specific QuicSession subclass.  This class owns the underlying
 // QuicConnection and QuicConnectionHelper objects.  The connection stores
 // a non-owning pointer to the helper so this session needs to ensure that
 // the helper outlives the connection.
 
 #ifndef NET_QUIC_QUIC_CLIENT_SESSION_H_
@@ skipping 155 matching lines @@
   int ResumeCryptoConnect(const CompletionCallback& callback);
 
   // Causes the QuicConnectionHelper to start reading from the socket
   // and passing the data along to the QuicConnection.
   void StartReading();
 
   // Close the session because of |error| and notifies the factory
   // that this session has been closed, which will delete the session.
   void CloseSessionOnError(int error, QuicErrorCode quic_error);
 
+  // Close the session because of |error| and notifies the factory later that
+  // this session has been closed, which will delete the session.
+  void CloseSessionOnErrorAndNotifyFactoryLater(int error,
+                                                QuicErrorCode quic_error);
+
   base::Value* GetInfoAsValue(const std::set<HostPortPair>& aliases);
 
   const BoundNetLog& net_log() const { return net_log_; }
 
   base::WeakPtr<QuicClientSession> GetWeakPtr();
 
   // Returns the number of client hello messages that have been sent on the
   // crypto stream. If the handshake has completed then this is one greater
   // than the number of round-trips needed for the handshake.
   int GetNumSentClientHellos() const;
@@ skipping 14 matching lines @@
 
   typedef std::set<Observer*> ObserverSet;
   typedef std::list<StreamRequest*> StreamRequestQueue;
 
   QuicReliableClientStream* CreateOutgoingReliableStreamImpl();
   // A completion callback invoked when a read completes.
   void OnReadComplete(int result);
 
   void OnClosedStream();
 
+  // Close the session because of |error| and records it in UMA histogram.
+  void RecordAndCloseSessionOnError(int error, QuicErrorCode quic_error);
+
   // A Session may be closed via any of three methods:
   // OnConnectionClosed - called by the connection when the connection has been
   //     closed, perhaps due to a timeout or a protocol error.
   // CloseSessionOnError - called from the owner of the session,
   //     the QuicStreamFactory, when there is an error.
   // OnReadComplete - when there is a read error.
   // This method closes all stream and performs any necessary cleanup.
   void CloseSessionOnErrorInner(int net_error, QuicErrorCode quic_error);
 
   void CloseAllStreams(int net_error);
@@ skipping 36 matching lines @@
   // on this session. Existing stream will continue to be processed.
   bool going_away_;
   base::WeakPtrFactory<QuicClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicClientSession);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CLIENT_SESSION_H_