Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053243003: Revert of Merge cellspace into old pointer space (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Merge cellspace into old pointer space (patchset #8 id:180001 of https://codereview.chromium.org/1010803012/) Reason for revert: Causes test failures on ARM bots related to cells and write barriers. Original issue's description: > Merge cellspace into old pointer space > > BUG= > > Committed: https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 > Cr-Commit-Position: refs/heads/master@{#27707} TBR=hpayer@chromium.org,balazs.kilvady@imgtec.com,yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9e3e0aaa88f72cce7ba8beff093358959b2a6ebd Cr-Commit-Position: refs/heads/master@{#27711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -97 lines) Patch
M include/v8.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/counters.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.h View 4 chunks +18 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 23 chunks +65 lines, -7 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 16 chunks +47 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/store-buffer-inl.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects.h View 3 chunks +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +11 lines, -1 line 0 comments Download
M src/snapshot/serialize.h View 1 chunk +4 lines, -8 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of Merge cellspace into old pointer space
5 years, 8 months ago (2015-04-09 18:15:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053243003/1
5 years, 8 months ago (2015-04-09 18:16:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 18:16:42 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 18:16:56 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e3e0aaa88f72cce7ba8beff093358959b2a6ebd
Cr-Commit-Position: refs/heads/master@{#27711}

Powered by Google App Engine
This is Rietveld 408576698