src/heap/objects-visiting-inl.h - Issue 1053243003: Revert of Merge cellspace into old pointer space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1053243003: Revert of Merge cellspace into old pointer space (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/objects-visiting-inl.h

diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h

index 104c60900d04a40b8bdbf5dd4a152663ba67e46f..010bbfa1e5107be4b075124f894ff66645784c03 100644

--- a/src/heap/objects-visiting-inl.h

+++ b/src/heap/objects-visiting-inl.h

@@ -233,7 +233,7 @@

RelocInfo* rinfo) {

DCHECK(rinfo->rmode() == RelocInfo::CELL);

Cell* cell = rinfo->target_cell();

- heap->mark_compact_collector()->RecordRelocSlot(rinfo, cell);

+ // No need to record slots because the cell space is not compacted during GC.

if (!rinfo->host()->IsWeakObject(cell)) {

StaticVisitor::MarkObject(heap, cell);

}

« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/spaces.h » ('j') | no next file with comments »