src/heap/store-buffer.cc - Issue 1053243003: Revert of Merge cellspace into old pointer space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/store-buffer.cc

Issue 1053243003: Revert of Merge cellspace into old pointer space (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/store-buffer.cc

diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc

index 1dc0357a15fe720452e2f4d70b3cc5c029731283..c07ffbfe645963c8a8351c19a0827d6f3358fff3 100644

--- a/src/heap/store-buffer.cc

+++ b/src/heap/store-buffer.cc

@@ -536,6 +536,7 @@

// functions to reduce the number of unnecessary clashes.

hash_sets_are_empty_ = false; // Hash sets are in use.

for (Address* current = start_; current < top; current++) {

+ DCHECK(!heap_->cell_space()->Contains(*current));

DCHECK(!heap_->code_space()->Contains(*current));

uintptr_t int_addr = reinterpret_cast<uintptr_t>(*current);

// Shift out the last bits including any tags.

« no previous file with comments | « src/heap/spaces.cc ('k') | src/heap/store-buffer-inl.h » ('j') | no next file with comments »