aura: Remove layerless windows.

aura: Remove layerless windows.

Layerless windows are only used in unit tests today, and add
complexity in that a NativeWidgetAura can not rely on there
being a layer present. In practice, having a layer per Window
is not unreasonable overhead, and is simpler. The way to render
something into the same layer is to use a separate View instead
of a separate Window.

R=sky
BUG=466426
Committed: https://crrev.com/b161836dff98bccf59f00f4c5730f15e20c6969e
Cr-Commit-Position: refs/heads/master@{#323610}

[danakj, 2015-04-01 18:43:11]

danakj@chromium.org changed reviewers:
+ piman@chromium.org

[danakj, 2015-04-01 20:14:30]

Here's how it can look to remove layer-less aura Windows.

[piman, 2015-04-01 22:26:31]

lgtm

[Ben Goodger (Google), 2015-04-02 05:48:00]

To answer your comment in the bug, the reason we have windows without
layers is that some windows don't render, they exist in the window
hierarchy as nodes only to enforce draw ordering. In Ash for example we
create many windows for this purpose. What overhead is associated with
having a layer?

-Ben

On Wed, Apr 1, 2015 at 1:14 PM, <danakj@chromium.org> wrote:

> Reviewers: sky, piman (Very slow to review),
>
> Message:
> Here's how it can look to remove layer-less aura Windows.
>
> Description:
> aura: Remove layerless windows.
>
> R=sky
> BUG=466426
>
> Please review this at https://codereview.chromium.org/1050713002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+158, -866 lines):
>   M ash/display/cursor_window_controller.cc
>   M ash/display/mirror_window_controller.cc
>   M ash/display/screen_position_controller_unittest.cc
>   M ash/drag_drop/drag_drop_tracker.cc
>   M ash/root_window_controller.cc
>   M ash/root_window_controller_unittest.cc
>   M ash/shelf/shelf_layout_manager_unittest.cc
>   M ash/shell/keyboard_controller_proxy_stub.cc
>   M ash/shell_unittest.cc
>   M ash/test/ash_test_base.cc
>   M ash/wm/ash_focus_rules_unittest.cc
>   M ash/wm/dock/docked_window_resizer_unittest.cc
>   M ash/wm/drag_window_resizer_unittest.cc
>   M ash/wm/maximize_mode/workspace_backdrop_delegate.cc
>   M ash/wm/stacking_controller_unittest.cc
>   M ash/wm/system_gesture_event_filter_unittest.cc
>   M ash/wm/toplevel_window_event_handler_unittest.cc
>   M ash/wm/workspace/multi_window_resize_controller_unittest.cc
>   M ash/wm/workspace/workspace_event_handler_unittest.cc
>   M ash/wm/workspace/workspace_layout_manager_unittest.cc
>   M ash/wm/workspace/workspace_window_resizer_unittest.cc
>   M ash/wm/workspace_controller_unittest.cc
>   M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
>   M chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc
>   M content/browser/media/capture/desktop_capture_device_aura_unittest.cc
>   M content/browser/renderer_host/render_widget_host_view_aura.cc
>   M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
>   M content/browser/web_contents/aura/window_slider_unittest.cc
>   M content/browser/web_contents/web_contents_view_aura.cc
>   M content/browser/web_contents/web_contents_view_aura_browsertest.cc
>   M ui/aura/BUILD.gn
>   M ui/aura/aura.gyp
>   M ui/aura/demo/demo_main.cc
>   M ui/aura/test/aura_test_base.cc
>   M ui/aura/test/test_windows.cc
>   M ui/aura/window.h
>   M ui/aura/window.cc
>   D ui/aura/window_layer_type.h
>   M ui/aura/window_tree_host.cc
>   M ui/aura/window_unittest.cc
>   M ui/keyboard/keyboard_controller.cc
>   M ui/keyboard/keyboard_controller_unittest.cc
>   M ui/views/controls/native/native_view_host_aura.cc
>   M ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
>   M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
>   M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
>   M ui/views/widget/native_widget_aura_unittest.cc
>   M ui/views/widget/native_widget_mac.mm
>   M ui/views/widget/native_widget_mac_unittest.mm
>   M ui/views/widget/widget.h
>   M ui/views/widget/widget.cc
>   M ui/wm/core/shadow_controller_unittest.cc
>   M ui/wm/core/transient_window_manager_unittest.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2015-04-02 16:57:03]

On Wed, Apr 1, 2015 at 10:47 PM, Ben Goodger (Google) <ben@chromium.org>
wrote:

> To answer your comment in the bug, the reason we have windows without
> layers is that some windows don't render, they exist in the window
> hierarchy as nodes only to enforce draw ordering. In Ash for example we
> create many windows for this purpose. What overhead is associated with
> having a layer?
>

The overhead for a layer that does not draw content is cheap. What it does
is during the creation of a frame, it's position/transform/clip are
considered if they are present. Making a layer for every view would
probably not be amazing today, as that would be many hundreds of layers**.
Making a layer for every window seems perfectly reasonable and more on the
order of 10s, and is what we're doing right now. So I don't think we need
to optimize for this at the Window level, views is already doing a good job
here.

FWIW I found no usage of WINDOW_LAYER_NONE outside of unit tests (all
window_unittests, and one mac unit test).

** Non-drawing ui::Layers will get even cheaper as we move past
slimming-paint/impl-side-painting and can take advantage of the "property
trees" stuff in development, since the paint team is actively working on
making things even cheaper for scenes with large numbers of layers (more
than the UI compositor ever has).


>
> -Ben
>
> On Wed, Apr 1, 2015 at 1:14 PM, <danakj@chromium.org> wrote:
>
>> Reviewers: sky, piman (Very slow to review),
>>
>> Message:
>> Here's how it can look to remove layer-less aura Windows.
>>
>> Description:
>> aura: Remove layerless windows.
>>
>> R=sky
>> BUG=466426
>>
>> Please review this at https://codereview.chromium.org/1050713002/
>>
>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+158, -866 lines):
>>   M ash/display/cursor_window_controller.cc
>>   M ash/display/mirror_window_controller.cc
>>   M ash/display/screen_position_controller_unittest.cc
>>   M ash/drag_drop/drag_drop_tracker.cc
>>   M ash/root_window_controller.cc
>>   M ash/root_window_controller_unittest.cc
>>   M ash/shelf/shelf_layout_manager_unittest.cc
>>   M ash/shell/keyboard_controller_proxy_stub.cc
>>   M ash/shell_unittest.cc
>>   M ash/test/ash_test_base.cc
>>   M ash/wm/ash_focus_rules_unittest.cc
>>   M ash/wm/dock/docked_window_resizer_unittest.cc
>>   M ash/wm/drag_window_resizer_unittest.cc
>>   M ash/wm/maximize_mode/workspace_backdrop_delegate.cc
>>   M ash/wm/stacking_controller_unittest.cc
>>   M ash/wm/system_gesture_event_filter_unittest.cc
>>   M ash/wm/toplevel_window_event_handler_unittest.cc
>>   M ash/wm/workspace/multi_window_resize_controller_unittest.cc
>>   M ash/wm/workspace/workspace_event_handler_unittest.cc
>>   M ash/wm/workspace/workspace_layout_manager_unittest.cc
>>   M ash/wm/workspace/workspace_window_resizer_unittest.cc
>>   M ash/wm/workspace_controller_unittest.cc
>>   M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
>>   M chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc
>>   M content/browser/media/capture/desktop_capture_device_aura_unittest.cc
>>   M content/browser/renderer_host/render_widget_host_view_aura.cc
>>   M content/browser/renderer_host/render_widget_host_view_aura_
>> unittest.cc
>>   M content/browser/web_contents/aura/window_slider_unittest.cc
>>   M content/browser/web_contents/web_contents_view_aura.cc
>>   M content/browser/web_contents/web_contents_view_aura_browsertest.cc
>>   M ui/aura/BUILD.gn
>>   M ui/aura/aura.gyp
>>   M ui/aura/demo/demo_main.cc
>>   M ui/aura/test/aura_test_base.cc
>>   M ui/aura/test/test_windows.cc
>>   M ui/aura/window.h
>>   M ui/aura/window.cc
>>   D ui/aura/window_layer_type.h
>>   M ui/aura/window_tree_host.cc
>>   M ui/aura/window_unittest.cc
>>   M ui/keyboard/keyboard_controller.cc
>>   M ui/keyboard/keyboard_controller_unittest.cc
>>   M ui/views/controls/native/native_view_host_aura.cc
>>   M ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
>>   M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
>>   M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
>>   M ui/views/widget/native_widget_aura_unittest.cc
>>   M ui/views/widget/native_widget_mac.mm
>>   M ui/views/widget/native_widget_mac_unittest.mm
>>   M ui/views/widget/widget.h
>>   M ui/views/widget/widget.cc
>>   M ui/wm/core/shadow_controller_unittest.cc
>>   M ui/wm/core/transient_window_manager_unittest.cc
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2015-04-02 17:40:29]

sounds like a nice cleanup then!

On Thu, Apr 2, 2015 at 9:51 AM, Dana Jansens <danakj@chromium.org> wrote:

> On Wed, Apr 1, 2015 at 10:47 PM, Ben Goodger (Google) <ben@chromium.org>
> wrote:
>
>> To answer your comment in the bug, the reason we have windows without
>> layers is that some windows don't render, they exist in the window
>> hierarchy as nodes only to enforce draw ordering. In Ash for example we
>> create many windows for this purpose. What overhead is associated with
>> having a layer?
>>
>
> The overhead for a layer that does not draw content is cheap. What it does
> is during the creation of a frame, it's position/transform/clip are
> considered if they are present. Making a layer for every view would
> probably not be amazing today, as that would be many hundreds of layers**.
> Making a layer for every window seems perfectly reasonable and more on the
> order of 10s, and is what we're doing right now. So I don't think we need
> to optimize for this at the Window level, views is already doing a good job
> here.
>
> FWIW I found no usage of WINDOW_LAYER_NONE outside of unit tests (all
> window_unittests, and one mac unit test).
>
> ** Non-drawing ui::Layers will get even cheaper as we move past
> slimming-paint/impl-side-painting and can take advantage of the "property
> trees" stuff in development, since the paint team is actively working on
> making things even cheaper for scenes with large numbers of layers (more
> than the UI compositor ever has).
>
>
>>
>> -Ben
>>
>> On Wed, Apr 1, 2015 at 1:14 PM, <danakj@chromium.org> wrote:
>>
>>> Reviewers: sky, piman (Very slow to review),
>>>
>>> Message:
>>> Here's how it can look to remove layer-less aura Windows.
>>>
>>> Description:
>>> aura: Remove layerless windows.
>>>
>>> R=sky
>>> BUG=466426
>>>
>>> Please review this at https://codereview.chromium.org/1050713002/
>>>
>>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>>
>>> Affected files (+158, -866 lines):
>>>   M ash/display/cursor_window_controller.cc
>>>   M ash/display/mirror_window_controller.cc
>>>   M ash/display/screen_position_controller_unittest.cc
>>>   M ash/drag_drop/drag_drop_tracker.cc
>>>   M ash/root_window_controller.cc
>>>   M ash/root_window_controller_unittest.cc
>>>   M ash/shelf/shelf_layout_manager_unittest.cc
>>>   M ash/shell/keyboard_controller_proxy_stub.cc
>>>   M ash/shell_unittest.cc
>>>   M ash/test/ash_test_base.cc
>>>   M ash/wm/ash_focus_rules_unittest.cc
>>>   M ash/wm/dock/docked_window_resizer_unittest.cc
>>>   M ash/wm/drag_window_resizer_unittest.cc
>>>   M ash/wm/maximize_mode/workspace_backdrop_delegate.cc
>>>   M ash/wm/stacking_controller_unittest.cc
>>>   M ash/wm/system_gesture_event_filter_unittest.cc
>>>   M ash/wm/toplevel_window_event_handler_unittest.cc
>>>   M ash/wm/workspace/multi_window_resize_controller_unittest.cc
>>>   M ash/wm/workspace/workspace_event_handler_unittest.cc
>>>   M ash/wm/workspace/workspace_layout_manager_unittest.cc
>>>   M ash/wm/workspace/workspace_window_resizer_unittest.cc
>>>   M ash/wm/workspace_controller_unittest.cc
>>>   M chrome/browser/ui/ash/launcher/chrome_launcher_
>>> controller_unittest.cc
>>>   M chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc
>>>   M content/browser/media/capture/desktop_capture_device_aura_
>>> unittest.cc
>>>   M content/browser/renderer_host/render_widget_host_view_aura.cc
>>>   M content/browser/renderer_host/render_widget_host_view_aura_
>>> unittest.cc
>>>   M content/browser/web_contents/aura/window_slider_unittest.cc
>>>   M content/browser/web_contents/web_contents_view_aura.cc
>>>   M content/browser/web_contents/web_contents_view_aura_browsertest.cc
>>>   M ui/aura/BUILD.gn
>>>   M ui/aura/aura.gyp
>>>   M ui/aura/demo/demo_main.cc
>>>   M ui/aura/test/aura_test_base.cc
>>>   M ui/aura/test/test_windows.cc
>>>   M ui/aura/window.h
>>>   M ui/aura/window.cc
>>>   D ui/aura/window_layer_type.h
>>>   M ui/aura/window_tree_host.cc
>>>   M ui/aura/window_unittest.cc
>>>   M ui/keyboard/keyboard_controller.cc
>>>   M ui/keyboard/keyboard_controller_unittest.cc
>>>   M ui/views/controls/native/native_view_host_aura.cc
>>>   M ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
>>>   M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
>>>   M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
>>>   M ui/views/widget/native_widget_aura_unittest.cc
>>>   M ui/views/widget/native_widget_mac.mm
>>>   M ui/views/widget/native_widget_mac_unittest.mm
>>>   M ui/views/widget/widget.h
>>>   M ui/views/widget/widget.cc
>>>   M ui/wm/core/shadow_controller_unittest.cc
>>>   M ui/wm/core/transient_window_manager_unittest.cc
>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-04-02 17:42:30]

LGTM

[danakj, 2015-04-02 17:46:05]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-02 17:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1050713002/#ps60001
(title: "layerless: rebase")

[commit-bot: I haz the power, 2015-04-02 17:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1050713002/60001

[danakj, 2015-04-02 18:48:12]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2015-04-02 18:49:35]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-04-02 18:51:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1050713002/60001

[commit-bot: I haz the power, 2015-04-03 05:14:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-03 20:31:21]

Patchset 4 (id:??) landed as
https://crrev.com/b161836dff98bccf59f00f4c5730f15e20c6969e
Cr-Commit-Position: refs/heads/master@{#323610}