Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1049383003: Postpone rail application for touch scrolling - chrome side. (Closed)

Created:
5 years, 8 months ago by tdresser
Modified:
5 years, 8 months ago
Reviewers:
jdduke (slow), ccameron
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sadrul, tdresser+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, jdduke+watch_chromium.org, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Postpone rail application for touch scrolling - chrome side. This postpones rail application for touch scrolling. Eventually we'll postpone the application of rails into the scrolling logic, to enable scrollers which opt out of rails. This is a followup to https://codereview.chromium.org/1052433003/. BUG=469789

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -84 lines) Patch
M content/renderer/input/input_handler_proxy.cc View 2 chunks +27 lines, -5 lines 2 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 14 chunks +30 lines, -9 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/events/gesture_detection/gesture_detection_switches.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/events/gesture_detection/gesture_detection_switches.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 5 chunks +17 lines, -11 lines 1 comment Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/snap_scroll_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/snap_scroll_controller.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/snap_scroll_controller_unittest.cc View 3 chunks +32 lines, -38 lines 0 comments Download
M ui/events/gesture_event_details.h View 4 chunks +23 lines, -3 lines 0 comments Download
M ui/events/gesture_event_details.cc View 1 chunk +21 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ccameron
https://codereview.chromium.org/1049383003/diff/1/content/renderer/input/input_handler_proxy.cc File content/renderer/input/input_handler_proxy.cc (right): https://codereview.chromium.org/1049383003/diff/1/content/renderer/input/input_handler_proxy.cc#newcode461 content/renderer/input/input_handler_proxy.cc:461: // InputHandler. Oh, crap, I didn't do my TODO ...
5 years, 8 months ago (2015-04-01 17:20:25 UTC) #2
tdresser
https://codereview.chromium.org/1049383003/diff/1/content/renderer/input/input_handler_proxy.cc File content/renderer/input/input_handler_proxy.cc (right): https://codereview.chromium.org/1049383003/diff/1/content/renderer/input/input_handler_proxy.cc#newcode461 content/renderer/input/input_handler_proxy.cc:461: // InputHandler. On 2015/04/01 17:20:25, ccameron wrote: > Oh, ...
5 years, 8 months ago (2015-04-01 17:22:45 UTC) #3
jdduke (slow)
5 years, 8 months ago (2015-04-01 17:40:49 UTC) #5 
https://codereview.chromium.org/1049383003/diff/1/ui/events/gesture_detection...
File ui/events/gesture_detection/gesture_provider.cc (right):

https://codereview.chromium.org/1049383003/diff/1/ui/events/gesture_detection...
ui/events/gesture_detection/gesture_provider.cc:323: if
(!PostponeRailApplication() &&
We've worked hard to keep globals out of the gesture detection code, this should
be an argument to the gesture detection config.

Powered by Google App Engine
This is Rietveld 408576698