[DevTools] Show LastModified and ResponseTime of ServiceWorker script in DevTools

[DevTools] Show LastModified and ResponseTime of ServiceWorker script in DevTools

This cl depends on https://codereview.chromium.org/1037933002

BUG=466871
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192818

[horo, 2015-03-30 08:11:57]

Patchset #1 (id:1) has been deleted

[horo, 2015-03-30 08:23:40]

horo@chromium.org changed reviewers:
+ dgozman@chromium.org

[horo, 2015-03-30 08:23:41]

dgozman@
Could you please review this?

[dgozman, 2015-03-30 12:54:23]

This patch includes https://codereview.chromium.org/1039983003/. Should we close
the latter?

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/resources/ServiceWorkersView.js (right):

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:327: var
scriptLastModifiedText = WebInspector.UIString("Last-Modified: ") + (new
Date(version.scriptLastModified * 1000)).toConsoleTime();
WI.UIString("Last-Modified: %s", <last modified value>)

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:331: if
(version.scriptResponseTime) {
As a user, I don't understand the "Response time" value. What does it mean?
Let's provide explanation in title, or even legend for the whole SW view.

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:333: var
scriptResponseTimeText = WebInspector.UIString("Response time: ") + (new
Date(version.scriptResponseTime * 1000)).toConsoleTime();
ditto

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/resources/serviceWorkersView.css (right):

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/serviceWorkersView.css:190:
.service-workers-error-icon,
Instead of these styles, just use custom element "dt-icon-label" and set it's
type. See smallIcon.css for available types.

[horo, 2015-03-30 15:05:40]

> This patch includes https://codereview.chromium.org/1039983003/. Should we
close
> the latter?

Sorry, I wrongly uploaded Patch Set 3.
I need to land 3 patches in this order.
1. blink: https://codereview.chromium.org/1039983003/
2. chromium: https://codereview.chromium.org/1037933002/
3. blink: https://codereview.chromium.org/1048763002/

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/resources/ServiceWorkersView.js (right):

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:327: var
scriptLastModifiedText = WebInspector.UIString("Last-Modified: ") + (new
Date(version.scriptLastModified * 1000)).toConsoleTime();
On 2015/03/30 12:54:23, dgozman wrote:
> WI.UIString("Last-Modified: %s", <last modified value>)

Done.

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:331: if
(version.scriptResponseTime) {
On 2015/03/30 12:54:23, dgozman wrote:
> As a user, I don't understand the "Response time" value. What does it mean?
> Let's provide explanation in title, or even legend for the whole SW view.

Changed to "Server response time: "

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:333: var
scriptResponseTimeText = WebInspector.UIString("Response time: ") + (new
Date(version.scriptResponseTime * 1000)).toConsoleTime();
On 2015/03/30 12:54:23, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/resources/serviceWorkersView.css (right):

https://codereview.chromium.org/1048763002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/resources/serviceWorkersView.css:190:
.service-workers-error-icon,
On 2015/03/30 12:54:23, dgozman wrote:
> Instead of these styles, just use custom element "dt-icon-label" and set it's
> type. See smallIcon.css for available types.

Done.

[dgozman, 2015-03-30 15:22:16]

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
File Source/devtools/front_end/resources/ServiceWorkersView.js (right):

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:326: var
scriptLastModifiedDiv = scriptURLDiv.createChild("div", "service-workers-info");
You can just create "dt-icon-label" in scriptURLDiv, set it's type and
createTextChild inside.

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:329:
scriptLastModifiedDiv.createChild("div", "service-workers-info-message
service-worker-script-last-modified").createTextChild(scriptLastModifiedText);
I don't see where you use these classes.

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:335:
scriptResponseTimeDiv.createChild("div", "service-workers-info-message
service-worker-script-response-time").createTextChild(scriptResponseTimeText);
ditto

[horo, 2015-03-30 15:39:52]

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
File Source/devtools/front_end/resources/ServiceWorkersView.js (right):

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:326: var
scriptLastModifiedDiv = scriptURLDiv.createChild("div", "service-workers-info");
On 2015/03/30 15:22:16, dgozman wrote:
> You can just create "dt-icon-label" in scriptURLDiv, set it's type and
> createTextChild inside.

Done.

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:329:
scriptLastModifiedDiv.createChild("div", "service-workers-info-message
service-worker-script-last-modified").createTextChild(scriptLastModifiedText);
On 2015/03/30 15:22:15, dgozman wrote:
> I don't see where you use these classes.

Removed service-workers-info-message.
service-worker-script-last-modified is used in LayouTest.

https://codereview.chromium.org/1048763002/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/resources/ServiceWorkersView.js:335:
scriptResponseTimeDiv.createChild("div", "service-workers-info-message
service-worker-script-response-time").createTextChild(scriptResponseTimeText);
On 2015/03/30 15:22:16, dgozman wrote:
> ditto

Removed service-workers-info-message.
service-worker-script-response-time is used in LayouTest.

[dgozman, 2015-03-30 15:53:33]

lgtm

[horo, 2015-03-31 06:29:32]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-03-31 06:29:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048763002/100001

[horo, 2015-03-31 07:13:55]

The CQ bit was unchecked by horo@chromium.org

[horo, 2015-03-31 07:15:54]

Patchset #5 (id:100001) has been deleted

[horo, 2015-03-31 07:15:59]

The CQ bit was checked by horo@chromium.org

[horo, 2015-03-31 07:15:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1048763002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-03-31 07:16:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048763002/120001

[commit-bot: I haz the power, 2015-03-31 09:23:50]

Committed patchset #5 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192818