[DevTools] Send ServiceWorkerVersion.ScriptLastModified and ScriptResponseTime to DevTools window.

[DevTools] Send ServiceWorkerVersion.ScriptLastModified and ScriptResponseTime to DevTools window.

This cl depends on https://codereview.chromium.org/1039983003/

BUG=466871
Committed: https://crrev.com/5d811a93fd256878164ffc951514d9a7057e5fea
Cr-Commit-Position: refs/heads/master@{#322985}

[horo, 2015-03-26 11:22:58]

horo@chromium.org changed reviewers:
+ dgozman@chromium.org, falken@chromium.org

[horo, 2015-03-26 11:22:59]

falken@
Could you please review this cl?

dgozman@
Could you please review
content/browser/devtools/protocol/service_worker_handler.cc?

[dgozman, 2015-03-26 11:33:22]

devtools lgtm

https://codereview.chromium.org/1037933002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1037933002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:90:
->set_update_time(version_info.update_time.ToJsTime()));
We use ToDoubleT for timestamps in protocol.

[horo, 2015-03-26 11:35:57]

Thank you!

https://codereview.chromium.org/1037933002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1037933002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:90:
->set_update_time(version_info.update_time.ToJsTime()));
On 2015/03/26 11:33:22, dgozman wrote:
> We use ToDoubleT for timestamps in protocol.

Done.

[falken, 2015-03-30 00:46:29]

https://codereview.chromium.org/1037933002/diff/30001/content/browser/service...
File content/browser/service_worker/service_worker_register_job.cc (right):

https://codereview.chromium.org/1037933002/diff/30001/content/browser/service...
content/browser/service_worker/service_worker_register_job.cc:405:
registration()->installing_version()->set_update_time(now);
Update is an operation on registration, not version, so it seems odd to make
update_time a property of versions. You can't update a version; the update
process creates a new version.

If the idea is to store a timestamp for when a version is created, calling it
creation time would make more sense. Can you explain more the desired UI?

[horo, 2015-03-30 08:22:46]

On 2015/03/30 00:46:29, falken wrote:
>
https://codereview.chromium.org/1037933002/diff/30001/content/browser/service...
> File content/browser/service_worker/service_worker_register_job.cc (right):
> 
>
https://codereview.chromium.org/1037933002/diff/30001/content/browser/service...
> content/browser/service_worker/service_worker_register_job.cc:405:
> registration()->installing_version()->set_update_time(now);
> Update is an operation on registration, not version, so it seems odd to make
> update_time a property of versions. You can't update a version; the update
> process creates a new version.
> 
> If the idea is to store a timestamp for when a version is created, calling it
> creation time would make more sense. Can you explain more the desired UI?

I discussed with PM(kbx@) and changed to show the Last-Modified and response
time of the script instead of the update time of versions.
It is because the update time of version is not useful for developers.
https://code.google.com/p/chromium/issues/detail?id=466871#c17

dgozman@ and falken@
Could you please review CLs again?

https://codereview.chromium.org/1039983003/
https://codereview.chromium.org/1037933002/
https://codereview.chromium.org/1048763002/

[falken, 2015-03-30 09:02:22]

sw lgtm. I'm not so familiar with DevTools testing... what's the plan for
testing the new behavior? Would it be a layout test in devtools/?

[horo, 2015-03-30 09:21:19]

On 2015/03/30 09:02:22, falken wrote:
> sw lgtm. I'm not so familiar with DevTools testing... what's the plan for
> testing the new behavior? Would it be a layout test in devtools/?

We have http/tests/inspector/service-workers/.
I will add new LayoutTest for this.

[dgozman, 2015-03-30 11:11:11]

devtools still lgtm

[horo, 2015-03-30 23:01:18]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-03-30 23:02:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037933002/50001

[commit-bot: I haz the power, 2015-03-30 23:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-30 23:20:47]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[horo, 2015-03-31 00:44:32]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2015-03-31 00:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037933002/50001

[commit-bot: I haz the power, 2015-03-31 02:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 02:21:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2015-03-31 02:27:03]

The CQ bit was checked by horo@chromium.org

[horo, 2015-03-31 02:27:04]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1037933002/#ps70001
(title: "fix test failure")

[commit-bot: I haz the power, 2015-03-31 02:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037933002/70001

[commit-bot: I haz the power, 2015-03-31 03:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 03:28:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2015-03-31 04:42:26]

The CQ bit was checked by horo@chromium.org

[horo, 2015-03-31 04:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1037933002/#ps90001
(title: "fix test failure")

[commit-bot: I haz the power, 2015-03-31 04:42:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037933002/90001

[commit-bot: I haz the power, 2015-03-31 05:51:25]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-03-31 05:51:52]

Patchset 6 (id:??) landed as
https://crrev.com/5d811a93fd256878164ffc951514d9a7057e5fea
Cr-Commit-Position: refs/heads/master@{#322985}