Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1039983003: [DevTools] Introduce ServiceWorkerVersion.ScriptLastModified/ScriptResponseTime (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Introduce ServiceWorkerVersion.ScriptLastModified/ScriptResponseTime BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192764

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add descriptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
horo
dgozman@ Could you please review this?
5 years, 8 months ago (2015-03-30 08:23:15 UTC) #2
dgozman
https://codereview.chromium.org/1039983003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1039983003/diff/1/Source/devtools/protocol.json#newcode4110 Source/devtools/protocol.json:4110: { "name": "scriptResponseTime", "type": "number", "optional": true} I don't ...
5 years, 8 months ago (2015-03-30 11:12:20 UTC) #3
horo
https://codereview.chromium.org/1039983003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1039983003/diff/1/Source/devtools/protocol.json#newcode4110 Source/devtools/protocol.json:4110: { "name": "scriptResponseTime", "type": "number", "optional": true} On 2015/03/30 ...
5 years, 8 months ago (2015-03-30 14:15:51 UTC) #4
dgozman
lgtm
5 years, 8 months ago (2015-03-30 14:24:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039983003/20001
5 years, 8 months ago (2015-03-30 15:06:21 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 16:29:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192764

Powered by Google App Engine
This is Rietveld 408576698