media-internals: Simplify the code path for creating a media log entry

media-internals: Simplify the code path for creating a media log entry

Changes MediaLog::CreateLogEvent() to instead be a helper AddLogEvent() that
both creates and adds the event, and has signature and utility matching LogCB.
This means various media code pieces no longer must have their own LogCB
implementations that CreateLogEvent()+AddEvent().

BUG=471902, 260005
TEST=no media_unittest, layout, or chrome://media-internals log regression observed

Committed: https://crrev.com/aafe49fe9061c489906351db41c318473d1951af
Cr-Commit-Position: refs/heads/master@{#323149}

[wolenetz, 2015-03-31 21:01:01]

wolenetz@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[wolenetz, 2015-03-31 21:01:01]

Dale, this CL is motivated by your comment at
https://codereview.chromium.org/1041353002/diff/20001/media/mojo/services/moj...

Please take a look at patch set 2.
This patch also depends on landing https://codereview.chromium.org/1041353002/
first.

[DaleCurtis, 2015-03-31 21:08:50]

lgtm

[wolenetz, 2015-03-31 21:12:36]

Thanks for review! I'll send to CQ once
https://codereview.chromium.org/1041353002/ lands.

[wolenetz, 2015-03-31 22:06:21]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2015-03-31 22:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047313002/20001

[commit-bot: I haz the power, 2015-03-31 22:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 22:26:20]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[wolenetz, 2015-03-31 23:00:46]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2015-03-31 23:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1047313002/#ps40001
(title: "Fix compile on Android")

[commit-bot: I haz the power, 2015-03-31 23:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1047313002/40001

[commit-bot: I haz the power, 2015-04-01 00:07:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-01 00:08:18]

Patchset 3 (id:??) landed as
https://crrev.com/aafe49fe9061c489906351db41c318473d1951af
Cr-Commit-Position: refs/heads/master@{#323149}

[jianli, 2015-04-01 00:34:38]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1049393002/ by jianli@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%2....