media-internals: Simplify the code path for creating a media log entry

media/base/media_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media_log.h"
 
 #include <string>
 
 #include "base/atomic_sequence_num.h"
 #include "base/json/json_writer.h"
@@ skipping 218 matching lines @@
   scoped_ptr<MediaLogEvent> event(
       CreateEvent(MediaLogEvent::BUFFERED_EXTENTS_CHANGED));
   // These values are headed to JS where there is no int64 so we use a double
   // and accept loss of precision above 2^53 bytes (8 Exabytes).
   event->params.SetDouble("buffer_start", start);
   event->params.SetDouble("buffer_current", current);
   event->params.SetDouble("buffer_end", end);
   return event.Pass();
 }
 
-scoped_ptr<MediaLogEvent> MediaLog::CreateLogEvent(MediaLogLevel level,
-                                                   const std::string& message) {
-  const MediaLogEvent::Type type = MediaLogLevelToEventType(level);
-  const std::string param = MediaLogLevelToString(level);
-  scoped_ptr<MediaLogEvent> event(CreateEvent(type));
-  event->params.SetString(param, message);
-  return event.Pass();
+void MediaLog::AddLogEvent(MediaLogLevel level, const std::string& message) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogLevelToEventType(level)));
+  event->params.SetString(MediaLogLevelToString(level), message);
+  AddEvent(event.Pass());
 }
 
 void MediaLog::SetStringProperty(
     const std::string& key, const std::string& value) {
   scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
   event->params.SetString(key, value);
   AddEvent(event.Pass());
 }
 
 void MediaLog::SetIntegerProperty(
@@ skipping 31 matching lines @@
     : level_(level), log_cb_(log_cb) {
 }
 
 LogHelper::~LogHelper() {
   if (log_cb_.is_null())
     return;
   log_cb_.Run(level_, stream_.str());
 }
 
 }  //namespace media