Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: media/renderers/default_renderer_factory.cc

Issue 1047313002: media-internals: Simplify the code path for creating a media log entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MEDIA_LOG_INFO_ERROR_DEBUG
Patch Set: Fix compile on Android Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/default_renderer_factory.cc
diff --git a/media/renderers/default_renderer_factory.cc b/media/renderers/default_renderer_factory.cc
index e423cdd66dd2e8d9b6984b6e9f9be513d5fc869c..81162d35e2a1956cb4e2aece8fde4b58cbd034d0 100644
--- a/media/renderers/default_renderer_factory.cc
+++ b/media/renderers/default_renderer_factory.cc
@@ -23,15 +23,6 @@
namespace media {
-#if !defined(MEDIA_DISABLE_FFMPEG)
-
-static void AddLogEntry(const scoped_refptr<MediaLog>& media_log,
- MediaLog::MediaLogLevel level,
- const std::string& message) {
- media_log->AddEvent(media_log->CreateLogEvent(level, message));
-}
-#endif
-
DefaultRendererFactory::DefaultRendererFactory(
const scoped_refptr<MediaLog>& media_log,
const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories,
@@ -55,7 +46,7 @@ scoped_ptr<Renderer> DefaultRendererFactory::CreateRenderer(
#if !defined(MEDIA_DISABLE_FFMPEG)
audio_decoders.push_back(new FFmpegAudioDecoder(
- media_task_runner, base::Bind(&AddLogEntry, media_log_)));
+ media_task_runner, base::Bind(&MediaLog::AddLogEvent, media_log_)));
#endif
audio_decoders.push_back(new OpusAudioDecoder(media_task_runner));
« no previous file with comments | « media/mojo/services/mojo_renderer_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698