Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: media/base/media_log.cc

Issue 1047313002: media-internals: Simplify the code path for creating a media log entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MEDIA_LOG_INFO_ERROR_DEBUG
Patch Set: Fix compile on Android Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index 745957d5c0cae3befbcb0a75ca416ea4fb18b4e4..b32942daa05cd2e66b639a647933dab7aa7d6c93 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -236,13 +236,10 @@ scoped_ptr<MediaLogEvent> MediaLog::CreateBufferedExtentsChangedEvent(
return event.Pass();
}
-scoped_ptr<MediaLogEvent> MediaLog::CreateLogEvent(MediaLogLevel level,
- const std::string& message) {
- const MediaLogEvent::Type type = MediaLogLevelToEventType(level);
- const std::string param = MediaLogLevelToString(level);
- scoped_ptr<MediaLogEvent> event(CreateEvent(type));
- event->params.SetString(param, message);
- return event.Pass();
+void MediaLog::AddLogEvent(MediaLogLevel level, const std::string& message) {
+ scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogLevelToEventType(level)));
+ event->params.SetString(MediaLogLevelToString(level), message);
+ AddEvent(event.Pass());
}
void MediaLog::SetStringProperty(
« no previous file with comments | « media/base/media_log.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698