Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1047213002: Finish 'MIPS: [turbofan] Add backend support for float32 operations.' (Closed)

Created:
5 years, 8 months ago by balazs.kilvady
Modified:
5 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Finish 'MIPS: [turbofan] Add backend support for float32 operations.' Add missing parts of the port to MIPS/MIPS64 implementations. BUG= Committed: https://crrev.com/6cb0e87cead8ee081472db731e6e3d2b03f344d4 Cr-Commit-Position: refs/heads/master@{#27551}

Patch Set 1 #

Patch Set 2 : Fix #1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -176 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 2 chunks +42 lines, -54 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +42 lines, -54 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 6 chunks +80 lines, -36 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 6 chunks +85 lines, -32 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 7 chunks +51 lines, -0 lines 1 comment Download
M test/cctest/test-assembler-mips64.cc View 1 7 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
paul.l...
LGTM.
5 years, 8 months ago (2015-03-31 17:54:16 UTC) #2
balazs.kilvady
5 years, 8 months ago (2015-03-31 17:56:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047213002/20001
5 years, 8 months ago (2015-03-31 17:57:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 18:26:01 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6cb0e87cead8ee081472db731e6e3d2b03f344d4 Cr-Commit-Position: refs/heads/master@{#27551}
5 years, 8 months ago (2015-03-31 18:26:25 UTC) #7
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 13:00:26 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1047213002/diff/20001/test/cctest/test-assemb...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/1047213002/diff/20001/test/cctest/test-assemb...
test/cctest/test-assembler-mips.cc:49: // clang-format off
please don't do this. clang-format off is meant to be used a small scope, not a
blanket thing for the entire file.

Powered by Google App Engine
This is Rietveld 408576698