Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1045283002: Implement PermissionDescriptor usage in Permissions API. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
whywhat
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement PermissionDescriptor usage in Permissions API. This is changing Permissions.query() to take an object instead of a PermissionName. The name is then expected inside the object. BUG=437770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192876

Patch Set 1 #

Patch Set 2 : no find copies #

Total comments: 17

Patch Set 3 : review comments #

Patch Set 4 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -45 lines) Patch
M LayoutTests/http/tests/permissions/resources/test-query.js View 1 2 1 chunk +62 lines, -15 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
A Source/modules/permissions/MidiPermissionDescriptor.idl View 1 1 chunk +7 lines, -0 lines 0 comments Download
A Source/modules/permissions/PermissionDescriptor.idl View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M Source/modules/permissions/PermissionStatus.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M Source/modules/permissions/PermissionStatus.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/permissions/Permissions.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/modules/permissions/Permissions.cpp View 2 chunks +35 lines, -8 lines 0 comments Download
M Source/modules/permissions/Permissions.idl View 1 chunk +1 line, -8 lines 0 comments Download
A Source/modules/permissions/PushPermissionDescriptor.idl View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-03-31 14:27:40 UTC) #2
whywhat
lgtm % nits & questions https://codereview.chromium.org/1045283002/diff/20001/LayoutTests/http/tests/permissions/resources/test-query.js File LayoutTests/http/tests/permissions/resources/test-query.js (right): https://codereview.chromium.org/1045283002/diff/20001/LayoutTests/http/tests/permissions/resources/test-query.js#newcode25 LayoutTests/http/tests/permissions/resources/test-query.js:25: return navigator.permissions.query({name:'midi', sysex: false}); ...
5 years, 8 months ago (2015-03-31 14:51:45 UTC) #3
mlamouri (slow - plz ping)
https://codereview.chromium.org/1045283002/diff/20001/LayoutTests/http/tests/permissions/resources/test-query.js File LayoutTests/http/tests/permissions/resources/test-query.js (right): https://codereview.chromium.org/1045283002/diff/20001/LayoutTests/http/tests/permissions/resources/test-query.js#newcode25 LayoutTests/http/tests/permissions/resources/test-query.js:25: return navigator.permissions.query({name:'midi', sysex: false}); On 2015/03/31 at 14:51:44, whywhat ...
5 years, 8 months ago (2015-03-31 20:24:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045283002/40001
5 years, 8 months ago (2015-03-31 20:25:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045283002/60001
5 years, 8 months ago (2015-03-31 20:56:29 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 22:39:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192876

Powered by Google App Engine
This is Rietveld 408576698