Source/modules/permissions/PermissionDescriptor.idl - Issue 1045283002: Implement PermissionDescriptor usage in Permissions API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/permissions/PermissionDescriptor.idl

Issue 1045283002: Implement PermissionDescriptor usage in Permissions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: no find copies Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/permissions/MidiPermissionDescriptor.idl ('K') | « Source/modules/permissions/MidiPermissionDescriptor.idl ('k') | Source/modules/permissions/PermissionStatus.h » ('j') | Source/modules/permissions/PermissionStatus.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 enum PermissionName {

	6 "geolocation",

	7 "notifications",

	8 "push",

	9 "midi"
	whywhat 2015/03/31 14:51:45 nit: alphabetical order? nit: alphabetical order? mlamouri (slow - plz ping) 2015/03/31 20:24:46 Done. Show quoted text On 2015/03/31 at 14:51:45, whywhat wrote: > nit: alphabetical order? Done.
	10 };

	11

	12 dictionary PermissionDescriptor {
	whywhat 2015/03/31 14:51:44 nit: comment, esp. that it's extendable by particu nit: comment, esp. that it's extendable by particular APIs for custom permissions mlamouri (slow - plz ping) 2015/03/31 20:24:46 Done. Show quoted text On 2015/03/31 at 14:51:44, whywhat wrote: > nit: comment, esp. that it's extendable by particular APIs for custom permissions Done.
	13 /* required */ PermissionName name;
	whywhat 2015/03/31 14:51:45 why 'required' is commented out? why 'required' is commented out? mlamouri (slow - plz ping) 2015/03/31 20:24:46 It's a WebIDL feature not implemented by Blink :( Show quoted text On 2015/03/31 at 14:51:45, whywhat wrote: > why 'required' is commented out? It's a WebIDL feature not implemented by Blink :( I opened https://code.google.com/p/chromium/issues/detail?id=472220
	14 };

OLD	NEW