Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2347)

Unified Diff: Source/modules/permissions/PermissionStatus.h

Issue 1045283002: Implement PermissionDescriptor usage in Permissions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/permissions/PermissionStatus.h
diff --git a/Source/modules/permissions/PermissionStatus.h b/Source/modules/permissions/PermissionStatus.h
index 1cb1c79363ef5d18d5de912a14b33aea1ebb322c..74d0af3cd0a1995cf0862f7dd161e3b731ee0703 100644
--- a/Source/modules/permissions/PermissionStatus.h
+++ b/Source/modules/permissions/PermissionStatus.h
@@ -18,6 +18,8 @@ namespace blink {
class ExecutionContext;
class ScriptPromiseResolver;
+// Expose the status of a given WebPermissionType for the current
+// ExecutionContext.
class PermissionStatus final
: public RefCountedGarbageCollectedEventTargetWithInlineData<PermissionStatus>
, public ContextLifecycleObserver {
@@ -28,6 +30,7 @@ public:
static PermissionStatus* take(ScriptPromiseResolver*, WebPermissionStatus*, WebPermissionType);
static void dispose(WebPermissionStatus*);
+ PermissionStatus(ExecutionContext*, WebPermissionStatus);
~PermissionStatus() override;
// EventTarget implementation.
@@ -37,15 +40,10 @@ public:
DECLARE_VIRTUAL_TRACE();
String status() const;
- // TODO: needs to be used by the IDL
- WebPermissionType type() const { return m_type; }
DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
private:
- explicit PermissionStatus(ExecutionContext*, WebPermissionType, WebPermissionStatus);
-
- WebPermissionType m_type;
WebPermissionStatus m_status;
};
« no previous file with comments | « Source/modules/permissions/PermissionDescriptor.idl ('k') | Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698