Source/modules/permissions/Permissions.idl - Issue 1045283002: Implement PermissionDescriptor usage in Permissions API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/permissions/Permissions.idl

Issue 1045283002: Implement PermissionDescriptor usage in Permissions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: no find copies Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/permissions/PermissionStatus.h ('K') | « Source/modules/permissions/Permissions.cpp ('k') | Source/modules/permissions/PushPermissionDescriptor.idl » ('j') | Source/modules/permissions/PushPermissionDescriptor.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Specification at:	5 // Specification at:

6 // https://w3c.github.io/permissions/	6 // https://w3c.github.io/permissions/

7	7

8 enum PermissionName {

9 "geolocation",

10 "notifications",

11 "push-notifications",

12 "midi-sysex"

13 };

14

15 [	8 [

16 Exposed=(Window,Worker),	9 Exposed=(Window,Worker),

17 GarbageCollected,	10 GarbageCollected,

18 RuntimeEnabled=Permissions	11 RuntimeEnabled=Permissions

19 ] interface Permissions {	12 ] interface Permissions {

20 [CallWith=ScriptState] Promise<PermissionStatus> query(PermissionName permis sion);	13 [CallWith=ScriptState] Promise<PermissionStatus> query(object permission);
	whywhat 2015/03/31 14:51:45 won't PermissionDescriptor work here? won't PermissionDescriptor work here? mlamouri (slow - plz ping) 2015/03/31 20:24:47 Yes and no. It would be we couldn't re-parse it to Show quoted text On 2015/03/31 at 14:51:45, whywhat wrote: > won't PermissionDescriptor work here? Yes and no. It would be we couldn't re-parse it to a specialized value because we wouldn't get the v8 value.
21 };	14 };

OLD	NEW